feat: API pipeline run get has execution summary#97
Open
yuechao-qin wants to merge 1 commit intoycq/api_pipeline_run_list_has_endedfrom
Open
feat: API pipeline run get has execution summary#97yuechao-qin wants to merge 1 commit intoycq/api_pipeline_run_list_has_endedfrom
yuechao-qin wants to merge 1 commit intoycq/api_pipeline_run_list_has_endedfrom
Conversation
This was referenced Feb 17, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 17, 2026
yuechao-qin
force-pushed
the
ycq/api_pipeline_run_get_has_ended
branch
from
78c4a89 to
96dfb6c
Compare
yuechao-qin
force-pushed
the
ycq/api_pipeline_run_list_has_ended
branch
from
ea578e3 to
489c797
Compare
Ark-kun
reviewed
Feb 19, 2026
| next_page_token=next_page_token, | ||
| ) | ||
|
|
||
| def _populate_execution_stats( |
Contributor
There was a problem hiding this comment.
In general, I prefer functions that return value, rather than methods that modify things in-palce.
Collaborator
There was a problem hiding this comment.
@yuechao-qin Seems like this comment is not addressed
yuechao-qin
force-pushed
the
ycq/api_pipeline_run_get_has_ended
branch
from
96dfb6c to
034f57b
Compare
yuechao-qin
force-pushed
the
ycq/api_pipeline_run_list_has_ended
branch
from
489c797 to
3df5bde
Compare
yuechao-qin
force-pushed
the
ycq/api_pipeline_run_list_has_ended
branch
from
3df5bde to
5014f69
Compare
yuechao-qin
force-pushed
the
ycq/api_pipeline_run_get_has_ended
branch
from
034f57b to
b25a858
Compare
morgan-wowk
requested changes
Feb 24, 2026
yuechao-qin
changed the base branch from
ycq/api_pipeline_run_list_has_ended
to
graphite-base/97
yuechao-qin
force-pushed
the
graphite-base/97
branch
from
5014f69 to
cec5214
Compare
yuechao-qin
force-pushed
the
ycq/api_pipeline_run_get_has_ended
branch
from
b25a858 to
8bb91aa
Compare
yuechao-qin
changed the base branch from
graphite-base/97
to
ycq/api_pipeline_run_list_has_ended
morgan-wowk
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Added execution statistics to the pipeline run get endpoint (
GET /api/pipeline_runs/{id}).What changed?
getmethod to optionally include execution statisticsinclude_execution_stats(default: False) to thegetmethod_populate_execution_statsHow to test?
include_execution_stats=TrueTestPipelineRunServiceGetclass to ensure the functionality works as expectedRun the new test cases in
tests/test_api_server_sql.py:Why make this change?
has_endedto the response of PieplineRunsService.list #87tangle-deployneeds to know if a specific pipeline run is completed